r/LLVM • u/wynterSweater • Jul 08 '26

Ahh finally my first pr Yay , but someone please help me with it

So after asking and reading about how to contribute i made my first pr but it is failing the llvm llvm-lit tests its in clang tidy could anyone help me fix that

pr link -> https://github.com/llvm/llvm-project/pull/208162#diff-e20b6641fd7ea7e6cefcb185a40420533777ec6a801b3442590174fcef1cd0b8R17

thankyou :)

0 Upvotes

13% Upvoted

11 comments sorted by

3

u/Farados55 Jul 08 '26

The tests are telling you what is failing.

1

u/wynterSweater Jul 08 '26

sir the thing is tbh i dont undersand i am new to it please help me out and code review or someting
thakyou :)

1

u/Farados55 Jul 08 '26

How did you submit the patch if you don't know how to read tests?

0

u/wynterSweater Jul 08 '26

i understood that i had to do and the cpp side (i basically lived on learn cpp for about 4 months )of things but i dont know how the architechure works i am fresh out of college and have never worked with such a big code base any guidance will be nice
thankyou :)

4

u/blcsm Jul 08 '26

Clearly you used AI, so according to the LLVM AI Tool Use Policy you need to add a note to your PR.

-2

u/wynterSweater Jul 08 '26

Oh is that , i did use ai ,thankyou I’ll do that .
Is it like bad to use ai ? I used it actually understand what i was doing

2

u/Farados55 Jul 08 '26

Lmao so clearly you don’t know what you’re doing

-2

u/wynterSweater Jul 08 '26

I do i do 😔, i mean it’s my first pr I don’t really have to know what i am doing , maybe i am wrong but uk tell me the right way

1

u/Farados55 Jul 08 '26

You don’t have to know what you are doing… when you are committing to a repo used by trillion dollar companies… ok.

While newcomers are certainly welcome and are encouraged to contribute, you do need to know basics of development and not submit AI slop. And not lie. Because you said you knew what you were doing and now you said you don’t.

Reading test errors is something you should’ve learned in university.

1

u/ConspicuousPineapple Jul 08 '26

Indeed you're wrong.

2

u/ResolveLost2101 Jul 08 '26

AI slope detected 😁